fix: apply spotless conditionally #1119
Conversation
|
@cruzach could you check if this fixes the issue for you? Also, sorry to bother you @ElviraBurchik but could you check if this doesn't break anything I've recently fixed within your setup? |
|
Yes, this fixes the issue I mentioned in my PR, thanks! |
kacperkapusciak
deleted the
@kacperkapusciak/apply-spotless-conditionally
branch
|
Hey @kacperkapusciak 👋 This branch works with our setup. Thank you! 🙌 |
|
hi @kacperkapusciak, sorry for the ping- do you think this would be published soon or should we revert/ |
|
@cruzach we can release a patch version with this change only if you think it would be better from Expo point of view. |
|
Yes please! We'd like to include the newest version in SDK 43, but use |
|
Should be ready as 3.7.1: https://github.com/software-mansion/react-native-screens/releases/tag/3.7.1 🎉 |
|
thankyou 🙏 |
Description
Fixes issue mentioned in #1118 with clashing Spotless configuration when developer's app also uses Spotless.
This PR makes spotless only load within
react-native-screensproject.Changes
Moved spotless configuration to separate file and load it conditionally using
apply fromsyntax.Test code and steps to reproduce
init a RN project, add
to build.gradle
yarn add react-native-screens, and try to build.Checklist